swayfx compat changes #84
Draft
+163
−262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikReider
reviewed
Jan 1, 2025
| int width = output->width; | ||
| int height = output->height; | ||
| struct wlr_buffer *wlr_buffer = NULL; | ||
|
|
||
| if (*fx_framebuffer == NULL) { | ||
| if (swapchain == NULL) { | ||
| printf("swapchain is null\n"); |
There was a problem hiding this comment.
Oops must've pushed a debug change
| @@ -565,6 +568,7 @@ struct wlr_renderer *fx_renderer_create_egl(struct wlr_egl *egl) { | |||
| wlr_egl_unset_current(renderer->egl); | |||
|
|
|||
| get_fx_shm_formats(renderer, &renderer->shm_texture_formats); | |||
| printf("made renderer\n"); | |||
There was a problem hiding this comment.
We should use wlr_log instead
There was a problem hiding this comment.
Oop that was a debugging print I think
WillPower3309
commented
Jan 1, 2025
types/scene/wlr_scene.c
Outdated
| @@ -2421,6 +2421,11 @@ bool wlr_scene_output_build_state(struct wlr_scene_output *scene_output, | |||
| timer->pre_render_duration = timespec_to_nsec(&duration); | |||
| } | |||
|
|
|||
| // TODO: we need to revisit this, this is a stopgap to ensure we can resume swayfx rebase | |||
There was a problem hiding this comment.
this feels wrong. We should sanity check this with scene upstream. How do they handle the case of output swapchain not being enabled here? Are we missing an initialization on the swayfx side?
| @@ -565,6 +568,7 @@ struct wlr_renderer *fx_renderer_create_egl(struct wlr_egl *egl) { | |||
| wlr_egl_unset_current(renderer->egl); | |||
|
|
|||
| get_fx_shm_formats(renderer, &renderer->shm_texture_formats); | |||
| printf("made renderer\n"); | |||
There was a problem hiding this comment.
Oop that was a debugging print I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to scenefx related to the swayfx rebase (WillPower3309/swayfx#367)